Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] Milter Greylist's use of POSIX threads is seriously broken

2004-06-07 by manu@netbsd.org

Matthias Scheler <tron@...> wrote:

> > How do you explain the errno being equal to 0? 
> Bad result checking? 

It looks okay:

$ grep cond_wait *
dump.c:                 if (pthread_cond_wait(&dump_sleepflag, &mutex) != 0)
dump.c:                     syslog(LOG_ERR, "pthread_cond_wait failed: %s\n",
sync.c:         if (pthread_cond_wait(&sync_sleepflag, &mutex) != 0)
sync.c:                 syslog(LOG_ERR, "pthread_cond_wait failed: %s\n", 

So pthread_cond_wait retunrs != 0 and doesn't set errno. I removed the return
value check in pthread_*_init for exactly the same reason. 

-- 
Emmanuel Dreyfus
Il y a 10 sortes de personnes dans le monde: ceux qui comprennent 
le binaire et ceux qui ne le comprennent pas.
manu@...

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.