Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] hash table acceleration breaks lazyaw

2006-03-27 by Hajimu UMEMOTO

Hi,

>>>>> On Mon, 27 Mar 2006 02:01:20 +0300
>>>>> Ranko Zivojnovic <ranko@...> said:

ranko> ! #define BUCKET_HASH_V6(sa, from, rcpt, bucket_count)		\
ranko> !   ((((uint32_t)(SADDR6(sa)->s6_addr)[3] &			\
ranko> !      (uint32_t)(((ipaddr *)&conf.c_match_mask)->in6.s6_addr)[3])\
ranko> !     ^ F2B_SPICE(from, rcpt))					\
ranko> !    % bucket_count)

It seems this test is broken for an IPv6.  Why do you check only
(uint32_t)(SADDR6(sa)->s6_addr)[3]?  We need to check whole address.

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@...  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.