Milter-greylist

Enrico Scholz
<enrico.scholz-jNDFPZUTrfQ+B2oLq8eQJv4efur1V5z/s0AfqQuZ5sE@...>
writes:

> This seems to happen when two hosts connect within a very short time. I
> think that GeoIP_id_by_name() is called for the second host while this
> function is still executed for the first one.  As both are operating on
> the same 'geoip_handle' handle, this will corrupt internal state when
> geoip is not reentrant.

While looking over the code it seems that other subsystems have similar
issues. E.g. 'p0f' uses a shared 'p0fsock' socket in non-atomic
reconnect-write-read sequences.  Ditto for 'spamd'.

Should there be added mutex locks to all these subsystems, or would it
make more sense to add locking to the calling instance?


Enrico