Milter-greylist

Hi,

> Here is milter-greylist-4.3.5
> 
> http://ftp.espci.fr/pub/milter-greylist/milter-greylist-4.3.5.tgz
> MD5 (milter-greylist-4.3.5.tgz) = 66fc347ddda423d0047dc96f6e26db7c
> 
> Here are the changes since 4.3.4. I just recovered from a cvs server 
> crash, so there might be some patches I missed. Please tell me if 
> you sent something that went unintegrated.
> 
>         Update .spec file for libcurl, GeoIP and p0f support (Chris 
> Bennett)        

A few queries here:

1. How does one get changes applied to the spec?

For dkim support, I added:
%define p0f 1
%{?build_p0f:%define p0f 1}

%define libdkim 1
%{?build_libdkim:%define libdkim 1}

to the top and then:

and then:

%if %{libGeoIP}
        --with-libGeoIP \
%endif
%if %{libdkim}
        --with-libdkim \
%endif

so it will compile with dkim support.

2. For this spec, I also had to change:

##%define user root
%define user smmsp
%{?build_user:%define user %{build_user}}

so it could run as "smmsp". I didn't have to do this with the milter-greylist
4.3.4 spec file but I do have to with this one?

My guess is it's the added "-u user" paramater on the start up (maybe the init
script has changed?). My milter-greylist 4.3.4 servers show:

# ps aux|grep greylist
smmsp    10807  0.0  0.3 186592 19536 ?        Ssl  Mar08   2:43
/usr/bin/milter-greylist -P /var/milter-greylist/milter-greylist.pid -p
/var/milter-greylist/milter-greylist.sock

while the newer milter-greylist 4.3.5 shows:

# ps aux|grep greylist
smmsp    29898  0.0  0.4 157412 10296 ?        Ssl  01:47   0:00
/usr/bin/milter-greylist -u smmsp -P /var/milter-greylist/milter-greylist.pid
-p /var/milter-greylist/milter-greylist.sock

3. the milter-greylist.sock file is "root:root" for 4.3.5, while it's
smmsp:smmsp for 4.3.4 as this shows, for 4.3.4:

# ll /usr/bin/milter-greylist /var/milter-greylist/milter-greylist.pid
/var/milter-greylist/milter-greylist.sock
-rwxr-xr-x 1 root  root  283252 Feb 28 21:24 /usr/bin/milter-greylist
-rw-r--r-- 1 smmsp smmsp      6 Mar  8 23:05
/var/milter-greylist/milter-greylist.pid
srwxr-xr-x 1 smmsp smmsp      0 Mar  8 23:05
/var/milter-greylist/milter-greylist.sock

while 4.3.5:

# ll /usr/bin/milter-greylist /var/milter-greylist/milter-greylist.pid
/var/milter-greylist/milter-greylist.sock
-rwxr-xr-x 1 root  root  281248 Mar 17 01:45 /usr/bin/milter-greylist
-rw-r--r-- 1 smmsp smmsp      6 Mar 17 01:47
/var/milter-greylist/milter-greylist.pid
srwxr-xr-x 1 root  root       0 Mar 17 01:47
/var/milter-greylist/milter-greylist.sock

I've only compiled the 4.3.5 spec on one mail server and am running mgl 4.3.5
only on that server. It still seems to be running fine but I'm concerned that
the milter-greylist.sock file is owned by root:root.

Is there something wrong with the init script to make it do this?

4. Addition of smmsp:smmsp chown to /var/milter-greylist

I had to add:

%post
/sbin/chkconfig --add milter-greylist
/bin/chown smmsp:smmsp /var/milter-greylist

to the spec file so the directory is owned by smmsp:smmsp otherwise
milter-greylist won't run. I know I can add a --user paramater? to the
rpmbuild line but it the spec really needs to be corrected for this to work
with just a normal:

rpmbuild -bb milter-greylist.spec

command.

Thanks.

Michael.