Milter-greylist

On Fri, Jul 09, 2010 at 10:06:48AM +0200, Enrico Scholz wrote:
> Enrico Scholz
> <enrico.scholz-jNDFPZUTrfQ+B2oLq8eQJv4efur1V5z/s0AfqQuZ5sE@...>
> writes:
> 
> > | milter-greylist: SPAMD/1.0 79 Timeout: (300 second timeout while trying to CHECK) 
> >
> > in my logfiles.  After analyzing the related network traffic, all these
> > messages have in common that they contain an ASCII \0 in their bodies.
> > This character is allowed by RFC 822 (but not in 2822 + 5322).
> 
> I have to correct this; <NULL> is completely valid e.g. in a
> 'Content-Transfer-Encoding: binary' MIME attachment submitted by using
> the 8BITMIME (RFC 1652) extension.

I just looked up a couple of things and it seems that various MUAs as
well as the Cyrus IMAP server won't handle a NULL properly or will
reject it altogether.

That said, while I never felt the need for accepting messages with NULL
characters, I also think that it should not be the job of milt.-greylist
to reject or sanitize those messages.  Thats what message_reject_char.
and friends are for.  Also there is a NULL_IN_BODY check in SpamAssassin
which tells me that they probably know how to deal with it.

So after re-reading your original patch, it now seems ok to me.

		Petar Bogdanovic