Milter-greylist

John Wood <john-misc@...> wrote:

> It looks like result = (priv->priv_dkimstat == DKIM_STAT_NOSIG); is the
> reason. This is strange because milter-greylist is linked against the
> same library as the DKIM milter running, which validates the signature
> just fine. While I don't understand all of the code, it is also 
> interesting to point out that while it seems to get NOSIG, the ACL for
> "pass" is matching; which also seems incorrect? as it should be NONE and
> not match: spf pass dkim pass.

Indeed, but perhaps we should focus on the first bug, that is:
DKIM_STAT_NOSIG.

In dkimcheck_error(), there is a log call. Do you get it in the logs?
And when do you reach it? A breakpoint and backtrace might be
insightful.

        case DKIM_STAT_NOSIG:
                mg_log(LOG_DEBUG, "DKIM failed: %s",
                       dkim_getresultstr(priv->priv_dkimstat));

                retval = SMFIS_CONTINUE;

Note the retval, which perhaps explains the match.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...