Milter-greylist

On Sat, Jan 29, 2011 at 03:17:41PM +0100, manu@... wrote:
> Emmanuel Dreyfus <manu@...> wrote:
> > I'm affraid you will have to grep conf_retain *.c and add this before
> > each occurence:
> 
> And while you are there, logging the thread ID will help:
>      if (GET_CONF())
>         mg_log(LOG_WARN, "%d: conf_retain called from %s",
>                        pthread_self(), __func__); 

I had to use LOG_WARNING but otherwise there was no particular issue with the
added lines.

> As I understand the problem you get could only occur if the same thread
> re-enter conf_retain. 

It seems to always be the same thread indeed.

[With the assertion in conf.c:352 intact]
Jan 29 16:43:37 milter-greylist: 673055056: conf_retain called from dumper
Jan 29 16:43:37 milter-greylist: conf.c:351 BUG: conf_retain called twice?
Jan 29 16:43:42 milter-greylist: 673055056: conf_retain called from dumper
Jan 29 16:43:42 milter-greylist: conf.c:351 BUG: conf_retain called twice?
Jan 29 16:43:47 milter-greylist: 673055056: conf_retain called from dumper
Jan 29 16:43:47 milter-greylist: conf.c:351 BUG: conf_retain called twice?

[With return in conf.c:352]
Jan 29 16:49:25 milter-greylist: 673055056: conf_retain called from dumper
Jan 29 16:49:25 milter-greylist: conf.c:351 BUG: conf_retain called twice?
Jan 29 16:57:30 milter-greylist: 673055056: conf_retain called from dumper
Jan 29 16:57:30 milter-greylist: conf.c:351 BUG: conf_retain called twice?

-- 
Francois Tigeot