Milter-greylist

shuttlebox <shuttlebox@...> wrote:

> I'm using 4.8.30 and grep:ed the sources, found no trace of O_SHLOCK.

Reading the sources, the flag is passed to open(2). In Solaris open(2)
man page, I find no way to get an unexclusive lock on the file.

The simplier solution is to define it as 0. Unix locks are advisory
anyway. We could add a flock(LOCK_SH) but it is probably not worth the
trouble.

Index: milter-greylist.c
===================================================================
RCS file: /cvsroot/milter-greylist/milter-greylist.c,v
retrieving revision 1.244
diff -U 4 -r1.244 milter-greylist.c
--- milter-greylist.c   25 Feb 2012 02:38:13 -0000      1.244
+++ milter-greylist.c   25 Feb 2012 15:50:48 -0000
@@ -2205,8 +2205,11 @@
        return;
 }
 
 #ifdef USE_DRAC
+#ifndef O_SHLOCK
+#define O_SHLOCK 0
+#endif /* O_SHLOCK */
 static int
 check_drac(dotted_ip)
        char *dotted_ip;
 {
-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...