On 2013-01-26 07:18, manu@... wrote: > Frantisek Hanzlik franta@... <mailto:franta%40hanzlici.cz>> wrote: > > > And yes, problem is only cosmetical, but these warnings fill logs > > IMO uselessly. Any of you suggested modifications will be good. > > We could do this, which remove the warning and let the user match an invalid > country. Opinions? > > if (priv->priv_ccode == NULL) > - mg_log(LOG_DEBUG, "GeoIP failed to lookup ip '%s'", ipstr); > - > + priv->priv_ccode = "ZZ"; I'd say that it is remotely possible that in some future there might be a state, country or planet coded as ZZ ;) So for such private dummy code I'd use an a-priori invalid symbol, i.e. "__" with the underscore char being reserved as a separator for country_locale codes. My 2c, //Jim
Message
Re: [milter-greylist] GeoIP failed to lookup ip 'PRIVATE_IP'
2013-01-26 by Jim Klimov