On 2013-08-10 18:52, manu@... wrote: > Jim Klimov <jimklimov@... <mailto:jimklimov%40cos.ru>> wrote: > > > * milter-greylist-4.4.3-override-packaging-strings.patch > > I am fine with the autoconf part, but you use it when displaying usage. > Why not add the new information after current output of milter-greylist > -r ? It looks made for it. Hmm... indeed, it looks like the proper place. I did not realize that there was a method to show the detailed release information. Still, the convention I see in many programs is to show the version and distro information as part of the help message, and/or as a separate "-V|--version" method. So I'd argue this output should be added to both locations in the code :) Also note that the hacked autoconf part can also influence the RPM spec-file, and maybe some other locations (depending on how they can receive the overridden variables - so far I tested the plain variables in the shell-script context of the generated configure script, and the config.h undef's and re-define's. If there are other avenues of the value propagation - they might be or not be handled by this fix. //Jim Klimov
Message
Re: [milter-greylist] Submitter DNS name resolution and forgery detection
2013-08-10 by Jim Klimov
Attachments
- No local attachments were found for this message.