Jim Klimov <jimklimov@...> wrote: > I tried to adhere to this myself, but I guess a few lines slipped > past, mostly due to long strings or tabbing... as an important > factor: what indentation to the unpublished guidelines prefer? > 4-space tabs? 8? Another? ;) The Unpublished Rules say sthat tabs are used as 8 spaces :-) > Would you require the style and/or structure changes like this > before accepting the patch? Well, since I will do it if you do not, I of course prefer if you do. It would also be nice to move the thing that happen after if ( priv->priv_hostname[0] == '[' ) to a separate function, for the sake of readability. -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz manu@...
Message
Re: [milter-greylist] Submitter DNS name resolution and forgery detection
2013-08-11 by manu@...