Milter-greylist

Remy Card <Remy.Card@...> wrote:

> > 2) Is the acl keyword useful at all? We could have greylist and
> > whitelist keywords without a leading acl.
> 
>       I  agree that the acl keyword is useless, but we already have a
> greylist keyword:

Oh right. I guess we'll have to live with the acl keyword.
 
>       "acl whitelist rcpt /.*/" was a quick hack.  Actually, I think that
> this line could be removed.  The default should be greylisting every mail when
> running in normal mode and whitelisting every mail when running in test mode.
> Thus, we can rely on this default action and we don't need to use this (ugly)
> hack.
(snip)
> > test mode would not affect the way you read the ACL, right?
> 
>       Of course not.  ACL would be interpreted the same way in normal or
> in test mode with the exception of the default action.

Well my idea is to keep the test mode working as is so that configs
don't get broken at upgrade time, but to deprecate it, because the ACL
setup will allow the same setup with a much more cleaner config. 

I was raising the concern of supporting the old syntax and test mode
with the new scheme. You'll have to "emulate" ACL with the older
keywords. The configuration parser will have to do this conversion while
loading the config:

addr X          ->      acl whitelist addr X
domain X        ->      acl whitelist domain X
from X          ->      acl whitelist from X
rcpt X          ->      acl whitelist rcpt X   if not testmode
rcpt X          ->      acl greylist rcpt X    if testmode      

The result of using testmode and the acl keywords at the same time
should probably be left unspecified: just don't do it, it's not
supported with the new ACL syntax.
 
-- 
Emmanuel Dreyfus
Il y a 10 sortes de personnes dans le monde: ceux qui comprennent 
le binaire et ceux qui ne le comprennent pas.
manu@...