Milter-greylist

Remy Card <Remy.Card@...> wrote:

>       I suggest to add a test at the beginning of sync_queue():
> 
>       if (peer->p_flags & P_LOCAL)
>               return;
> 
>       This will prevent milter-greylist from queuing records to a local
> peer.  And, BTW, this will fix a memory leak in milter-greylist (pending
> records that are added to the local peer list are never deallocated since
> their reference count will never be decremented).

The memory leak is limited because once the queue is full, it stops
growing.

Your analysis and your fix seem good to me. Did you tested it? Can I
commit it now? Should 1.6 include that fix? That will bound us to
another release candidate. Given that the problem is minor (a limited
chunk of ram held for nothing), I'd be in favor of only applying to the
developement branch and release 1.6 as is.
 
-- 
Emmanuel Dreyfus
Il y a 10 sortes de personnes dans le monde: ceux qui comprennent 
le binaire et ceux qui ne le comprennent pas.
manu@...