Milter-greylist

Hello,

May I suggest a small improvement for milter-greylist logging.

When milter-greylist does auto-whitelisting by external factors (such as
{greylist} macro being set) it writes only a short message to log. It
would be great if the tuple data is written as well. I mean:

Now:
mg_log(LOG_DEBUG,
       "whitelisted by {greylist}");

Todo:
mg_log(LOG_DEBUG,
       "%s: addr %s[%s] from %s to %s whitelisted by {greylist}",
       priv->priv_queueid, priv->priv_hostname, addrstr,
       priv->priv_from, *envrcpt);

Is there any reason not to do this?

Best regards,
Denis Solovyv

Denis Solovyov <elk@...> wrote:

> Is there any reason not to do this?

Perhaps some users wrote swript relying on log output. But we can still
have an option to get the improved version. For instance we could have a
configurable format string that gets the usual subsitutions.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

>> Is there any reason not to do this?
> Perhaps some users wrote swript relying on log output. But we can still
> have an option to get the improved version. For instance we could have a
> configurable format string that gets the usual subsitutions.

Thank you for your reply.

I guess the only thing a script can do with a current simple output line
is to count it. It won't be difficult to change scripts after extending
output... With a log output containing information about sender and
receiver we'll have much more great things for log analyzers to do.
Configurable format string here is overkill, I believe. Configuration
switch would be quite OK...

Best regards,
Denis Solovyov