Milter-greylist

Hi

I managed to find some time to blend the pending patch for delayed
rejection (but I did not tested it, so blame the contributor if it
breaks), and here is milter-greylist-1.7.5

http://ftp.espci.fr/pub/milter-greylist/milter-greylist-1.7.5.tgz
MD5 (milter-greylist-1.7.5.tgz) = b0f0bd40a799b6745226a386d52c03b6

What's new in 1.7.5:
        Documentation fixes (Gary Aitken, Per Holm)
        New broken site in the default whitelist
        Generate .spec file from configure
        Differentiate errors in dump file and config file
        Fix a build problem if getaddrinfo is absent (Lev Walkin)
        Don't sync with local addresses on FreeBSD 4.9 (Lev Walkin)
        Add a commented line for ::1 whitelisting in greylist.conf
        Delayed reject to cope better with sender callback (Moritz Both)

Note that delayed rejection is not enabled by default, you have to use
the delayedreject option.

Now it seems that no big feature is still awaiting for integration. We
have delayed reject and ACL, this sounds changes big enough for a big
version bump. If everyone is happy with 1.7.5, I'll turn it into 2.0rc1.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

At 08:01 PM 1.29.2005 +0100, manu@... wrote:
>
>Hi
>
>I managed to find some time to blend the pending patch for delayed
>rejection (but I did not tested it, so blame the contributor if it
>breaks), and here is milter-greylist-1.7.5
>
>http://ftp.espci.fr/pub/milter-greylist/milter-greylist-1.7.5.tgz
>MD5 (milter-greylist-1.7.5.tgz) = b0f0bd40a799b6745226a386d52c03b6
>
>What's new in 1.7.5:
>        Documentation fixes (Gary Aitken, Per Holm)
>        New broken site in the default whitelist
>        Generate .spec file from configure
>        Differentiate errors in dump file and config file
>        Fix a build problem if getaddrinfo is absent (Lev Walkin)
>        Don't sync with local addresses on FreeBSD 4.9 (Lev Walkin)
>        Add a commented line for ::1 whitelisting in greylist.conf
>        Delayed reject to cope better with sender callback (Moritz Both)
>
>Note that delayed rejection is not enabled by default, you have to use
>the delayedreject option.
>
>Now it seems that no big feature is still awaiting for integration. We
>have delayed reject and ACL, this sounds changes big enough for a big
>version bump. If everyone is happy with 1.7.5, I'll turn it into 2.0rc1.
>
>-- 
>Emmanuel Dreyfus

OS - 4.10-RELEASE-p2

Emmanuel: I have been using v-1.7.4 ever since it was released and seemed
to work okay. So, I jumped on the chance to update to this newer 1.7.5. I
used the same FBSD port that I used for 1.7.4, but got an error this time
about failed patch.

Here is the output - your thoughts please?:

--->  Session started at: Sat, 29 Jan 2005 23:27:44 -0600
--->  Upgrade of mail/milter-greylist started at: Sat, 29 Jan 2005 23:27:45
-0600
--->  Upgrading 'milter-greylist-1.7.4' to 'milter-greylist-1.7.5'
(mail/milter-greylist)
--->  Build of mail/milter-greylist started at: Sat, 29 Jan 2005 23:27:45
-0600
--->  Building '/usr/ports/mail/milter-greylist'
===>  Cleaning for rc_subr-1.31
===>  Cleaning for milter-greylist-1.7.5
===>  Vulnerability check disabled
===>  Extracting for milter-greylist-1.7.5
=> Checksum OK for milter-greylist-1.7.5.tgz.
===>  Patching for milter-greylist-1.7.5
===>  Applying FreeBSD patches for milter-greylist-1.7.5
1 out of 1 hunks failed--saving rejects to greylist.conf.rej
=> Patch patch-greylist.conf failed to apply cleanly.
=> Patch(es) patch-Makefile.in patch-dump.h applied cleanly.
*** Error code 1

Stop in /usr/ports/mail/milter-greylist.
** Command failed [exit code 1]: /usr/bin/script -qa
/tmp/portupgrade64870.0 make
** Fix the problem and try again.
--->  Build of mail/milter-greylist ended at: Sat, 29 Jan 2005 23:27:46
-0600 (consumed 00:00:00)
--->  Upgrade of mail/milter-greylist ended at: Sat, 29 Jan 2005 23:27:46
-0600 (consumed 00:00:00)
--->  Listing the results (+:done / -:ignored / *:skipped / !:failed)
        ! mail/milter-greylist (milter-greylist-1.7.4)  (patch error)


Happy trails,
Jack L. Stone

System Admin
Sage-american

Jack L. Stone <jacks@...> wrote:

> ===>  Applying FreeBSD patches for milter-greylist-1.7.5
> 1 out of 1 hunks failed--saving rejects to greylist.conf.rej

Not my fault: The FreeBSD package needs to be updated. Why does it needs
local patches, anyway?

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

On Sat, 29 Jan 2005 20:01:21 +0100 manu@netbsd.org wrote: MO MO Hi MO MO I managed to find some time to blend the pending patch for delayed MO rejection

At 09:18 AM 1.30.2005 +0100, manu@... wrote:
>
>Jack L. Stone <jacks@...> wrote:
>
>> ===>  Applying FreeBSD patches for milter-greylist-1.7.5
>> 1 out of 1 hunks failed--saving rejects to greylist.conf.rej
>
>Not my fault: The FreeBSD package needs to be updated. Why does it needs
>local patches, anyway?
>

Wasn't assigning blame -- in fact, figured I did something wrong, even
though the port approach is largely idiot-proof as long as it is up to
date. As I said, it worked with 1.7.4. I believe the port maintainer is/was
on this list and would have to answer your question.

Anyway, I skipped the port approach and just used:
./configure --with-user=smmsp && make && make install

...and all appears to have installed smoothly.

Thanks for a great milter!


Happy trails,
Jack L. Stone

System Admin
Sage-american

Hi,

>>>>> On Sun, 30 Jan 2005 09:18:01 +0100
>>>>> manu@... said:

manu> Jack L. Stone <jacks@...> wrote:

> ===>  Applying FreeBSD patches for milter-greylist-1.7.5
> 1 out of 1 hunks failed--saving rejects to greylist.conf.rej

manu> Not my fault: The FreeBSD package needs to be updated. Why does it needs
manu> local patches, anyway?

I don't see a port for 1.7.X.  I believe the latest version of the
FreeBSD port is for 1.6.

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@...  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/

At 12:31 AM 1.31.2005 +0900, Hajimu UMEMOTO wrote:
>
>Hi,
>
>>>>>> On Sun, 30 Jan 2005 09:18:01 +0100
>>>>>> manu@... said:
>
>manu> Jack L. Stone <jacks@...> wrote:
>
>> ===>  Applying FreeBSD patches for milter-greylist-1.7.5
>> 1 out of 1 hunks failed--saving rejects to greylist.conf.rej
>
>manu> Not my fault: The FreeBSD package needs to be updated. Why does it
needs
>manu> local patches, anyway?
>
>I don't see a port for 1.7.X.  I believe the latest version of the
>FreeBSD port is for 1.6.
>
>Sincerely,
>
>--
>Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan

You don't see it because the port needs you to revise it for the version
and checksum. My revision of it worked for 1.7.4... but, not 1.7.5


Happy trails,
Jack L. Stone

System Admin
Sage-american

"Jack L. Stone" <jacks@...> writes:

> Wasn't assigning blame -- in fact, figured I did something wrong, even
> though the port approach is largely idiot-proof as long as it is up to
> date. As I said, it worked with 1.7.4. I believe the port maintainer is/was
> on this list and would have to answer your question.

The port is providing support for stable versions of milter-greylist. There
is no reason to assume that a patch to be applied to 1.6 will work on later
versions. If it was the case with 1.7.4, then you were lucky.

I have a devel version of the port in my TODO list which would bring 1.7.5
to you. Because of several hard constraints I wasn't able to get it
rolled-out. It is still wip.

Regards.

Salut Emmanuel,

manu@... writes:

> Why does it needs local patches, anyway?

Until now (i.e port version 1.6):

I was conducted to patch milter-greylist.c and the Makefile in order to get
milter-greylist to compile and run smoothly under FBSD. See:
http://tinylink.com/?C5wXFzeh39 and http://tinylink.com/?yu94V4eNr1

I didn't spend time on autoXXXXX things because I don't like them and I have
very little spare time.

I will check with 1.7.5 if these are still mandatory during the next coming
days and would then submit a devel version of the port to the committers.

With the hope it clarifies.
Regards.

At 10:09 AM 1.31.2005 +0100, Cyril Guibourg wrote:
>
>"Jack L. Stone" <jacks@...> writes:
>
>> Wasn't assigning blame -- in fact, figured I did something wrong, even
>> though the port approach is largely idiot-proof as long as it is up to
>> date. As I said, it worked with 1.7.4. I believe the port maintainer is/was
>> on this list and would have to answer your question.
>
>The port is providing support for stable versions of milter-greylist. There
>is no reason to assume that a patch to be applied to 1.6 will work on later
>versions. If it was the case with 1.7.4, then you were lucky.
>
>I have a devel version of the port in my TODO list which would bring 1.7.5
>to you. Because of several hard constraints I wasn't able to get it
>rolled-out. It is still wip.
>
>Regards.
>
>

Indeed, the blame is all mine, because that little inner voice reminds me
that it might be risky to try that using an "older" port, although it works
most of the time. I do it because sometimes the other way doesn't work
either because of something do do with FBSD.

Just thought I would share the experience from one of the dumb users.
Sometimes it might be helpful.


Happy trails,
Jack L. Stone

System Admin
Sage-american

"Jack L. Stone" <jacks@...> writes:

> Indeed, the blame is all mine, because that little inner voice reminds me
> that it might be risky to try that using an "older" port, although it works
> most of the time. I do it because sometimes the other way doesn't work
> either because of something do do with FBSD.

No blame at all. Any feedback is always positive.

> Just thought I would share the experience from one of the dumb users.
> Sometimes it might be helpful.

It is. I'll do my best in order to send milter-greylist-devel PR soon.

Regards.